Comments on: iPhone – Downloading an image asynchronously. Revisited!

By: eBuildy

eBuildy — Wed, 25 Aug 2010 12:15:37 +0000

You can also use the magic TTImageView component from the Three20 library (the iOS framework built by the Facebook team)…

By: Richard Fliam

Richard Fliam — Mon, 21 Jun 2010 05:11:08 +0000

Old post to comment on but the leak occurs when the image reaches a retain count of zero and dealloc is called… before abortDownload or connectionDidFinishLoading: is called. This causes a general leak of downLoadedImage and m_requestData. Adding [self abortDownload]; to the dealloc method should fix this.

By: coder

coder — Wed, 19 May 2010 09:23:11 +0000

yes there is memory leak about InternetImage.
i just put a UIbutton in view.
i pasted your code buttons event:
[self downloadImageFromInternet:@"http://www.google.se/intl/en_com/images/logo_plain.png"];
there is no memory leak when you first tap the button.
but when you tap again
there are memory leaks:
InternetImage
UIImage

i also changed your connection code:

NSURL *url = [NSURL URLWithString:ImageUrl];
NSURLRequest *imageRequest = [[NSURLRequest alloc] initWithURL: url];
imageConnection = [[[NSURLConnection alloc] initWithRequest:imageRequest delegate:self] autorelease];

how can i solve it? i want to refresh the UIImage when the user taps button…
thanx…

By: Rutger Bevers

Rutger Bevers — Tue, 06 Apr 2010 21:38:33 +0000

I installed the example application on my iPhone.
It works most of the times, but sometimes the image is never loaded although I have a perfect connection.

You can test this by setting the iPhone into airplane mode and then turn it of. Now immediately when you get connection to the network start the application. The image will never load…

By: NIVETHA

NIVETHA — Tue, 25 Aug 2009 04:39:34 +0000

thank u

By: NIVETHA

NIVETHA — Tue, 25 Aug 2009 04:39:15 +0000

Really very nice post…… it helped me very much

By: Björn Sållarp

Björn Sållarp — Sun, 24 May 2009 05:54:03 +0000

Hello Cedric,

1. In the demo app I allocate a single InternetImage, there is no previous instance to release.
2. Same with ImageConnection.

I suspect the memory leaks are in your own implementation.

By: Cedric Vandendriessche

Cedric Vandendriessche — Sat, 23 May 2009 18:36:28 +0000

Nice piece of code! But I have to say there are 2 memory leaks.

1. You allocate InternetImage without releasing previous one.
2. Same as above but with imageConnection.

I also did this with an other class and also there there’s some general memory leak. I contacted apple about it and they told me to test it on 3.0 latest béta but I don’t want to lose my 2.2.1 install. Maybe you could test your code (or the URLCache apple sampleCode)

Thanks,

Cedric

By: Adeem Basraa

Adeem Basraa — Tue, 05 May 2009 12:33:49 +0000

Thax for a neat code

By: Björn Sållarp

Björn Sållarp — Sat, 02 May 2009 00:57:17 +0000

It is open source. It’s unfortunate that I wrote that in all the files previously. Everything on my blog is free to use and modify in any way you seem fit. I havn’t updated all the “old” code samples with a free to use statement, but my intent is that the code posted on my blog is free to use and modify by anyone.

If you appriciate and use the code I would like it if your link back from your site/blog.

Best regards,
Björn